This repository was archived by the owner on Jun 8, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 103
chore(x-goog-spanner-request-id): add x_goog_spanner_request_id as an attribute to OTEL spans - #1378
Merged
olavloite merged 2 commits intoMay 21, 2025
Conversation
@product-auto-label
product-auto-label
Bot
added
size: l
Pull request size is large.
api: spanner
Issues related to the googleapis/python-spanner API.
labels
May 21, 2025
@olavloite
olavloite
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 21, 2025
@yoshi-kokoro
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 21, 2025
... attribute to OTEL spans This change is effectively 3/3 of the work to complete x-goog-spanner-request-id propagation. While here instrumented batch_write as well to send over the header too. Updates #1261
odeke-em
force-pushed
the
propagate-x_goog_spanner_request_id-to-OTEL-span
branch
from
May 21, 2025 09:32
7da3a4f to
60346bb
Compare
@sakthivelmanii
sakthivelmanii
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 21, 2025
@yoshi-kokoro
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 21, 2025
olavloite
olavloite
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is effectively 3/3 of the work to complete x-goog-spanner-request-id propagation. While here instrumented batch_write as well to send over the header too.
Updates googleapis/google-cloud-python#15905