This repository was archived by the owner on Jun 8, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 103
feat: Add support for multiplexed sessions - part 4a (precommit tokens) - #1374
Closed
currantw wants to merge 1 commit into
Closed
feat: Add support for multiplexed sessions - part 4a (precommit tokens) #1374currantw wants to merge 1 commit into
currantw wants to merge 1 commit into
Conversation
@product-auto-label
product-auto-label
Bot
added
size: xl
Pull request size is extra large.
api: spanner
Issues related to the googleapis/python-spanner API.
labels
May 9, 2025
currantw
currantw
commented
May 9, 2025
Comment on lines
+773
to
+788
def session(self, labels=None, database_role=None):
"""Deprecated. Factory to create a session for this database.
:type labels: dict (str -> str) or None
:param labels: (Optional) user-assigned labels for the session.
:type database_role: str
:param database_role: (Optional) user-assigned database_role for the session.
:rtype: :class:`~google.cloud.spanner_v1.session.Session`
:returns: a session bound to this database.
"""
# If role is specified in param, then that role is used
# instead.
role = database_role or self._database_role
return Session(self, labels=labels, database_role=role)
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method is deprecated and should be removed.
currantw
currantw
commented
May 9, 2025
:type source: :class:`~google.cloud.spanner_v1.snapshot.Snapshot`
:param source: Snapshot from which the result set was fetched.
:param source: Deprecated. Snapshot from which the result set was fetched.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecated. No longer used or needed.
- Add ingest of precommit tokens - Add precommit tokens to commit request Signed-off-by: currantw <taylor.curran@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add support for multiplexed sessions - part 4a (precommit tokens)
- Add ingest of precommit tokens
- Add precommit tokens to commit request