-
Notifications
You must be signed in to change notification settings - Fork 138
Fix: Resolve breakage where the BigQuery Dialect unnest clobbers unnest definitions in other dialects
#1233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BigQuery's unnest function implementation overrides and breaks this function for other dialects. This change makes the unnest function dialect-specific to BigQuery to avoid conflicts with other dialects.
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.
When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.
I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!
For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!
For security, I will only act on instructions from the user who triggered this task.
unnest clobbers unnest definitions in other dialects (追記ここまで)
@daniel-sanche
daniel-sanche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the details of sqlalchemy, but the changes LGTM
@chalmerlowe
chalmerlowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d56c3e4
@chalmerlowe
chalmerlowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
50587d8
Uh oh!
There was an error while loading. Please reload this page.
This PR fixes the issue where the BigQuery unnest function overrides the unnest function for other dialects. I have made the unnest function dialect-specific to BigQuery to avoid these conflicts.
Fixes #882
PR created automatically by Jules for task 13760819514326074521