Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Stop Time Events in the past should be kept#502

Open
kylerchin wants to merge 1 commit intogoogle:master from
catenarytransit:master
Open

Stop Time Events in the past should be kept #502
kylerchin wants to merge 1 commit intogoogle:master from
catenarytransit:master

Conversation

@kylerchin
Copy link

@kylerchin kylerchin commented Sep 21, 2024

Maybe this should be recommended? This is extremely useful because it's helpful to have updates on when the train entered or left the station. Maybe we should state that past events should be the actual time in which the vehicle entered or left the stop.

derhuerst reacted with thumbs up emoji
Copy link

google-cla bot commented Sep 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kylerchin kylerchin changed the title (削除) CHange to recommended to keep past events. (削除ここまで) (追記) Stop Time Events in the past should be kept (追記ここまで) Sep 21, 2024
Copy link
Author

CLA issue should be fixed now! : 👍

Copy link
Contributor

skinkie commented Sep 21, 2024

-1 OpenGeo
It uses the wrong wording for what you want. Your intention is to receive information, thats fine. Your implementation an client is to fetch GTFS-RT at a regular interval. It may be that your update interval does not match the producers interval. What you want to describe is some sort of time to live for StopTimeEvents. Recommending to keep all historic StopTimeEvents bloats the GTFS tripUpdates distribution for no good reason, therefore it should not be recommended in the way you do.

gcamp and derhuerst reacted with thumbs up emoji

Copy link
Author

@skinkie There is good reason IMO to keep previous times, such as if a consumer server cold starts, or if a fault causes a significant loss in the cache data.

Copy link
Contributor

skinkie commented Sep 22, 2024

That is not a price to pay for the producer or all other consumers.

All these kinds of things could be fixed by a final implementation for Incrementality=DIFFERENTIAL, that would allow the majority of information be provided in tiny parts and your use case in the FULL_DATASET. Personally I think a HISTORY would be more appropriate.

derhuerst reacted with thumbs up emoji

@eliasmbd eliasmbd added Change: Clarification GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime Discussion Period The community engages in conversations to help refine and develop the proposal. Support: Needs Feedback labels Sep 23, 2024
Copy link
Contributor

miklcct commented Oct 8, 2024

I would say that past events should be kept as long as the trip hasn't been completed yet, otherwise consumers may have trouble working on delay propagation.

derhuerst reacted with thumbs up emoji

Copy link
Contributor

gcamp commented Oct 8, 2024

Can you explain how delay propagation is hard to do without the full trip?

Copy link
Contributor

miklcct commented Oct 8, 2024

If a bus is running early, well ahead of its scheduled time, lacking previous information may well cause the system into impossible state like time running backwards.

For example, OpenTripPlanner allows you to configure an option when such things do happen.

Copy link
Contributor

gcamp commented Oct 8, 2024

That's already in the spec :

Producers should not drop a past StopTimeUpdate if it refers to a stop with a scheduled arrival time in the future for the given trip (i.e. the vehicle has passed the stop ahead of schedule), as otherwise it will be concluded that there is no update for this stop.

What is proposed here is that producers should keep all past items regardless of if they are running early or late.

Copy link
Contributor

I agree that GTFS-RT should be reserved for realtime events only and not need to include historical data. A better way to communicate historical data would be via another standard, such as TIDES.

Copy link

github-actions bot commented Jan 7, 2025

This pull request has been automatically marked as stale because of lack of recent activity. It may be closed manually after one month of inactivity. Thank you for your contributions.

@github-actions github-actions bot added the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label Jan 7, 2025
Copy link
Contributor

miklcct commented Feb 21, 2025

I want to follow up this proposal. We are now planning to have a clean up of OpenTripPlanner real-time data, and missing data are now causing us problems how to fill in the remaining times to satisfy invariants (times must be increasing along the trip).

We should write the best practice of always producing all arrivals / departures for all stops for a trip into the recommendation document, in order to ensure that consumers won't add guesswork.

@github-actions github-actions bot removed the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label Feb 22, 2025
Copy link

This pull request has been automatically marked as stale because of lack of recent activity. It may be closed manually after one month of inactivity. Thank you for your contributions.

@github-actions github-actions bot added the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label May 23, 2025
@Sergiodero Sergiodero added the Former Governance Applies This proposal is subject to the former governance process which predates July 7, 2025. label Jul 7, 2025
@github-actions github-actions bot removed the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label Jul 8, 2025
@eliasmbd eliasmbd added Change type: Non-Functional Refers to important updates to the specification that do not significantly affect functionalities. and removed Change: Clarification labels Jul 9, 2025
Copy link

github-actions bot commented Oct 8, 2025

This pull request has been automatically marked as stale because of lack of recent activity. It may be closed manually after one month of inactivity. Thank you for your contributions.

@github-actions github-actions bot added the Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Change type: Non-Functional Refers to important updates to the specification that do not significantly affect functionalities. Discussion Period The community engages in conversations to help refine and develop the proposal. Former Governance Applies This proposal is subject to the former governance process which predates July 7, 2025. GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime Status: Stale Issues and Pull Requests that have remained inactive for 30 calendar days or more. Support: Needs Feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /