mirrored from https://skia.googlesource.com/skia
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Draft
Conversation
skia-codereview-bot
commented
Dec 12, 2025
This PR (HEAD: 2328921) has been imported to Gerrit for code review.
Please visit review.skia.org/1123497 to see it. Please CC yourself to the Gerrit change.
Note:
- Skia uses only Gerrit for reviews and submitting code (doc).
- All comments are handled within Gerrit. Any comments on the GitHub PR will be ignored.
- The PR author can continue to upload commits to the branch used by the PR in order to address feedback from Gerrit.
- Once the code is ready to be merged, a maintainer will submit the change on Gerrit and skia-codereview-bot will close this PR.
- Similarly, if a change is abandoned on Gerrit, the corresponding PR will be closed with a note.
@theoparis
theoparis
force-pushed
the
push-wnvntmnqzvkx
branch
from
January 20, 2026 21:57
2328921 to
8a5b71f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR fixes building Skia with Bazel 9 and 10. I marked it as a draft PR because emsdk needs some changes to fix
bazel test "//src/gpufor example and I'm waiting on the 9.0.0 release.Also, https://github.com/bazelbuild/rules_webtesting is archived and I had to temporarily remove it from the build files. I'm not sure what the replacement for this would be.