-
Notifications
You must be signed in to change notification settings - Fork 649
Support multiple -add_comment arguments #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple -add_comment arguments #987
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.35%. Comparing base (294ebfa) to head (282fd68).
Additional details and impacted files
@@ Coverage Diff @@ ## main #987 +/- ## ======================================= Coverage 67.35% 67.35% ======================================= Files 44 44 Lines 7792 7792 ======================================= Hits 5248 5248 Misses 2112 2112 Partials 432 432
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@aalexand
aalexand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the test implementation testFlags is different from internal/driver/flags.go. I'm not sure GoFlags there support multiple flags properly. Could you test that manually? Please also check that this change does not make the comma a separator as we want something like -add_comment=hello,world to add one comment, not two.
This makes it a bit nicer to annotate profiles when using external tools.