-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Added @InlineMe annotations to all deprecated collection factory functions that directly delegate to JDK constructors. - #8475
Open
copybara-service[bot] wants to merge 1 commit into
Open
Added @InlineMe annotations to all deprecated collection factory functions that directly delegate to JDK constructors. #8475copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_928611528
branch
2 times, most recently
from
June 15, 2026 20:24
36e30b3 to
ab8fd77
Compare
@copybara-service
copybara-service
Bot
changed the title
(削除) Added @InlineMe annotations to Lists.newArrayList() and Lists.newLinkedList(). (削除ここまで)
(追記) Added @InlineMe annotations to all deprecated collection factory functions that directly delegate to JDK constructors. (追記ここまで)
Jun 15, 2026
copybara-service
Bot
force-pushed
the
test_928611528
branch
from
June 15, 2026 20:38
ab8fd77 to
e5177d0
Compare
...tions that directly delegate to JDK constructors. RELNOTES=Added @InlineMe annotations to all deprecated collection factory functions that directly delegate to JDK constructors. PiperOrigin-RevId: 928611528
copybara-service
Bot
force-pushed
the
test_928611528
branch
from
June 15, 2026 20:52
e5177d0 to
546f687
Compare
ALIFKA-HUB
commented
Jun 25, 2026
alus
ExE-Boss
ExE-Boss
reviewed
Aug 6, 2026
Comment on lines
+456
to
462
@InlineMe(
replacement = "new EnumMap<>(checkNotNull(type))",
imports = "java.util.EnumMap",
staticImports = "com.google.common.base.Preconditions.checkNotNull")
public static <K extends Enum<K>, V extends @Nullable Object> EnumMap<K, V> newEnumMap(
Class<K> type) {
return new EnumMap<>(checkNotNull(type));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this null check is also performed by the implementation of the EnumMap constructor, and is thus redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Added @InlineMe annotations to all deprecated collection factory functions that directly delegate to JDK constructors.
RELNOTES=Added @InlineMe annotations to all deprecated collection factory functions that directly delegate to JDK constructors.