-
Notifications
You must be signed in to change notification settings - Fork 242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds EquateApproxDuration, a Comparer option that treats two time.Duration values as equal when they are within a given margin. it is the direct analog of EquateApproxTime but for raw durations rather than time.Time
the comparison normalizes order and checks the margin with !(x+a.margin < y) instead of subtracting, so it stays correct when the gap between the two values would overflow time.Duration, there is a MaxInt64 vs MinInt64 case covering that
no FilterValues wrapper here since unlike time.Time there is no zero-value special casing for durations. following the existing convention i did not add a runnable example, EquateApprox and EquateApproxTime have none either
fixes #394