-
Notifications
You must be signed in to change notification settings - Fork 43
Closed
Conversation
Contributor
alxmrs
commented
Sep 11, 2025
I think your commit history is a bit polluted -- it looks like you have the lazy loading PR here also. Mind cleaning that up before I provide a review?
Member
jdbcode
commented
Dec 18, 2025
@pvrraju it seems this and #253 are conflated. I've documented the preallocation as a feature request and linked to this PR in issue #280 so we have a record of the proposed implementation. I'm going close this. Before opening a new pull request with the change, can you please wait until #275 is in a pre or stable release. It's a major refactor that may affect the implementation and almost certainly the location of the changes you'll make. Thanks for your patience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR replaces nested list pre-allocation with NumPy arrays for tiles. The change:
np.empty(shape, dtype=object)instead of nested list comprehensionstiles[i][j][k]totiles[i, j, k]These changes improve code readability and may provide a slight performance enhancement.