-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[Translate ru] web-components/customelements #8372
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
i️ Googlers: Go here for more info.
WebFundBot
commented
Jan 9, 2020
Whoops!
There were 2 critical errors that broke the build and prevented it from being automatically deployed.
There were 7 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
ERRORS
src/content/ru/fundamentals/web-components/customelements.md - Unable to find specified 'book_path': "/web/fundamentals/_book.yaml"
src/content/ru/fundamentals/web-components/customelements.md - Unable to find specified 'project_path': "/web/fundamentals/_project.yaml"
WARNINGS
src/content/ru/fundamentals/web-components/customelements.md#L492 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L597 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L643 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L688 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L1078 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L1081 - '<script> tags are generally not allowed, please double check.
src/content/ru/fundamentals/web-components/customelements.md#L1078 - Common typo found: 'node' Should it be 'Node'?
@googlebot I consent
@googlebot I consent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm that the style matches the existing. I see several places where the markdown doesn't seem correct (spaces in anchors, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description should not span two lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #8938, should be:
})
Check out a review request at GitLocalize