-
Notifications
You must be signed in to change notification settings - Fork 363
Adds pinv to tensorflow backend (https://github.com/google/TensorNetwork/issues/844) #935
Conversation
@mganahl
mganahl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks good! Could you also add pinv to the AbstractBackend class, as well as numpy and jax backends?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test that actual @ tensor and tensor @ actual equal the identity (within the desired error)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would testing for all the criteria in https://en.wikipedia.org/wiki/Moore%E2%80%93Penrose_inverse be a better test? (As for an example given in tf's documentation, the product wasn't identity)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove the hermitian argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had included it as it was an argument for numpy. I'll remove it in the next commit.
Thanks for the review!
Uh oh!
There was an error while loading. Please reload this page.
Added pinv to tensorflow_backend.py and corresponding tests to tensorflow_backend_tests,py Issue: #844