-
Notifications
You must be signed in to change notification settings - Fork 363
Export typing information #923
Conversation
This commit adds the flag that the package contains typing information. Therefore other packages can use the typing data to check their code by mypy. Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages Signed-off-by: Jan Luca Naumann <j.naumann@fu-berlin.de>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
i️ Googlers: Go here for more info.
JanLuca
commented
May 20, 2021
@googlebot I signed it!
@alewis
alewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
mganahl
commented
May 31, 2021
Thanks for the PR! I'll fix the build and merge this.
codecov-commenter
commented
Jun 11, 2021
Codecov Report
@@ Coverage Diff @@ ## master #923 +/- ## ======================================= Coverage 98.04% 98.04% ======================================= Files 129 129 Lines 22394 22394 ======================================= Hits 21957 21957 Misses 437 437
Continue to review full report at Codecov.
|
This commit adds the flag that the package contains typing
information. Therefore other packages can use the typing data to check their
code by mypy.
Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages
Signed-off-by: Jan Luca Naumann j.naumann@fu-berlin.de