-
Notifications
You must be signed in to change notification settings - Fork 580
test(renderers/angular): add vitest browser testing #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+353
−1,408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@43081j
43081j
changed the title
(削除) test(renderers): add vitest browser testing (削除ここまで)
(追記) test(renderers/angular): add vitest browser testing (追記ここまで)
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There's no real test setup in the angular renderer project yet.
I was roaming around the codebase and figured I'd push this PR. It has the following:
build:unit-testchromiumso component tests run in a real browserNote i haven't touched angular in a long time, so a bunch of the tests may not be best practice. If there are better ways to do any of this, do let me know so i can update and learn.
It seems like we should also have some shared test utils file somewhere for things like the mock theme. Where would be sensible to put that?
Similarly, this
waitForSelectorfunction is a shame. I needed it because the default catalog uses dynamic imports andwhenStableisn't aware of these.whenStablecompletes long before the dynamic import, but i can't seem to find anything built-in we can wait for other than polling for the DOM.If you planned on having a different test setup, feel free to throw this PR away! It has been good to learn the codebase either way.