Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

src/goTest: Add command Test Current Package With Custom Run #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n1lesh wants to merge 3 commits into golang:master
base: master
Choose a base branch
Loading
from n1lesh:test-package-custom-run

Conversation

Copy link
Contributor

@n1lesh n1lesh commented Sep 1, 2021
edited by hyangah
Loading

This runs Test Current Package for a custom value passed for the -run flag.

Fixes #1734

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 1, 2021
Copy link
Collaborator

This PR (HEAD: a5281b3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/347209 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Collaborator

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/347209.
After addressing review feedback, remember to publish your drafts!

Copy link
Collaborator

This PR (HEAD: 581c7fb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/347209 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347209.
After addressing review feedback, remember to publish your drafts!

Copy link
Collaborator

This PR (HEAD: 2432329) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/347209 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Collaborator

Message from Nilesh Singh:

Patch Set 3:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/347209.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor Author

n1lesh commented Nov 25, 2021
edited
Loading

@firelizzard18 Would it be possible for you to review this?

Copy link
Contributor

@n1lesh I reviewed the CL, but I'm not part of the Go team so I can't do anything other than make suggestions. AFAIK, @hyangah is responsible for reviewing CLs on this repo.

n1lesh reacted with laugh emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a command to run test with custom value for -run flag

AltStyle によって変換されたページ (->オリジナル) /