-
Notifications
You must be signed in to change notification settings - Fork 18.4k
go/constant: fix complex != unknown comparison #75140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By the contract of Compare, if one operand is Unknown, the result must be false. Fixes golang#75137
ceeaf9c to
858ba89
Compare
This PR (HEAD: 858ba89) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/698955.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Alan Donovan:
Patch Set 1: Code-Review+2
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Andrei Efanov:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 1: Code-Review+1 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-25T19:17:15Z","revision":"796c3e704f67669c443bebb86b40d38876741b9a"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 1: Auto-Submit+1 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-28T23:09:06Z","revision":"796c3e704f67669c443bebb86b40d38876741b9a"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 1: -Commit-Queue Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-28T23:09:51Z","revision":"796c3e704f67669c443bebb86b40d38876741b9a"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):
- go on master (change 698955)
To reproduce, try gomote repro 8705251135320180465.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-28T23:40:37Z","revision":"796c3e704f67669c443bebb86b40d38876741b9a"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/698955.
After addressing review feedback, remember to publish your drafts!
By the contract of Compare, if one operand is Unknown, the result must be false. Fixes #75137 Change-Id: I56420fae808395f89769f5e5d448f9e1df9a622f GitHub-Last-Rev: 858ba89 GitHub-Pull-Request: #75140 Reviewed-on: https://go-review.googlesource.com/c/go/+/698955 Reviewed-by: Sean Liao <sean@liao.dev> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>
This PR is being closed because golang.org/cl/698955 has been merged.
Uh oh!
There was an error while loading. Please reload this page.
By the contract of Compare, if one operand is Unknown, the result must be
false.
Fixes #75137