-
Notifications
You must be signed in to change notification settings - Fork 18.4k
os: refactor to use runtime.Addcleanup #75039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: c17a079) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/696398.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-15T16:10:38Z","revision":"e78bd378c1ca4c406fe33277aaa35e84a12f8159"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
c17a079
to
01aa4eb
Compare
Message from xie cui:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):
- go on master (change 696398)
To reproduce, try gomote repro 8706455270157946993
.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 01aa4eb) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/696398.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from xie cui:
Patch Set 2: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-15T16:36:17Z","revision":"35fd6d9da249a2ee47b34c8b365cf2cca774dbd9"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):
- go on master (change 696398)
To reproduce, try gomote repro 8706453656451494225
.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 2: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-15T16:52:18Z","revision":"35fd6d9da249a2ee47b34c8b365cf2cca774dbd9"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):
- go on master (change 696398)
To reproduce, try gomote repro 8706452648818311249
.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Keith Randall:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
Message from Carlos Amedee:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/696398.
After addressing review feedback, remember to publish your drafts!
change expected leaked cleanups and/or finalizers from 2 to 5. 3 is come from stdin stdout stderr Change-Id: I2f971772229ee642d5a11e2271a010ac7ffdbf52
01aa4eb
to
b87100d
Compare
This PR (HEAD: b87100d) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/696398.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
go/src/os/file.go
Lines 72 to 74 in 0451816
these file will add leak cleanups.