-
Notifications
You must be signed in to change notification settings - Fork 18.4k
internal/runtime/maps: loop invariant code motion with h2(hash) by hand #74952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: Id17ef058d0f02c283250fc01426a514939e0b9b1
This PR (HEAD: 1ec8864) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/694016.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-09T02:05:24Z","revision":"714d93ea1fad8f398a829e6acc586d7365dbc17a"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):
- go on master (change 694016)
To reproduce, try gomote repro 8707052027780851777.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-09T02:39:02Z","revision":"714d93ea1fad8f398a829e6acc586d7365dbc17a"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):
- go on master (change 694016)
To reproduce, try gomote repro 8707049913994245233.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-09T02:59:14Z","revision":"714d93ea1fad8f398a829e6acc586d7365dbc17a"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Keith Randall:
Patch Set 1: Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Keith Randall:
Patch Set 1: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Michael Pratt:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Message from Dmitri Shuralyov:
Patch Set 1: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694016.
After addressing review feedback, remember to publish your drafts!
Change-Id: I0cd9763aeedfe326bc566da39b8be0d0ebd113ec GitHub-Last-Rev: 1ec8864 GitHub-Pull-Request: #74952 Reviewed-on: https://go-review.googlesource.com/c/go/+/694016 Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org>
This PR is being closed because golang.org/cl/694016 has been merged.
No description provided.