-
Notifications
You must be signed in to change notification settings - Fork 18.4k
internal/runtime: cleaner overflow checker #74943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: Ia3e88bdfa9eb71ddcf44ecfb0debc2f42450cfcf
This PR (HEAD: b939acc) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/694236.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-08T09:53:45Z","revision":"8dacbe6a9475bdc67f916cfdd8c871f6a21bdbae"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):
- go on master (change 694236)
To reproduce, try gomote repro 8707113159227654033.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-08T10:18:14Z","revision":"8dacbe6a9475bdc67f916cfdd8c871f6a21bdbae"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-08T10:18:43Z","revision":"8dacbe6a9475bdc67f916cfdd8c871f6a21bdbae"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from xie cui:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
Message from Michael Pratt:
Patch Set 1: Auto-Submit+1 Code-Review+2
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694236.
After addressing review feedback, remember to publish your drafts!
remove todo Change-Id: I4b10d7a8c26bea9296b321f53abd0330f2afc35a GitHub-Last-Rev: b939acc GitHub-Pull-Request: #74943 Reviewed-on: https://go-review.googlesource.com/c/go/+/694236 Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com>
This PR is being closed because golang.org/cl/694236 has been merged.
remove todo