-
Notifications
You must be signed in to change notification settings - Fork 18.4k
js/wasm: use the correctly captured this
in wasm_exec::_makeFuncWrapper
#74926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: c808d78) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/694035.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694035.
After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/694035.
After addressing review feedback, remember to publish your drafts!
c808d78
to
d95d724
Compare
This PR (HEAD: d95d724) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/694035.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Jobs Castellarin (Fabrizio Castellarin):
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694035.
After addressing review feedback, remember to publish your drafts!
Message from Jorropo:
Patch Set 3: Commit-Queue+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/694035.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-08T21:00:27Z","revision":"8a6d9396c9ca2374f2b758c5402ed9e3ec29c4a8"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/694035.
After addressing review feedback, remember to publish your drafts!
Message from Jorropo:
Patch Set 3: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/694035.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-js-wasm has failed with summary (view all results):
- go on master (change 694035)
To reproduce, try gomote repro 8707071214339491521
.
Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/694035.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/694035.
After addressing review feedback, remember to publish your drafts!
Uh oh!
There was an error while loading. Please reload this page.
Fixes #74927