-
Notifications
You must be signed in to change notification settings - Fork 18.4k
log/slog: add multiple handlers support for logger #74840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: aa3de5c) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/692237.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 1: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-01T14:09:54Z","revision":"336b858606052b52412f64daebd07b75acdf0005"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Ingo Oeser:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
aa3de5c
to
977ddd3
Compare
This PR (HEAD: 977ddd3) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/692237.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: 40249e4) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/692237.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Jes Cok:
Patch Set 3: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-04T14:08:00Z","revision":"5943eb55fbffa846a948f33f8fe166fc30e2fb51"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 3: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
CQ can't process the CL because its owner doesn't have a preferred email set in Gerrit settings.
You can set preferred email at https://go-review.googlesource.com/settings/#EmailAddresses
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 3: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-07T14:22:46Z","revision":"5943eb55fbffa846a948f33f8fe166fc30e2fb51"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 3: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 3: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Ingo Oeser:
Patch Set 3: Code-Review+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 3: Code-Review+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
40249e4
to
f36fb2d
Compare
This PR (HEAD: f36fb2d) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/692237.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Jes Cok:
Patch Set 4: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-09T07:56:04Z","revision":"30a88fd641ebb99c3c5e70ed432f95d493092a90"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 4: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
f36fb2d
to
9c40d1c
Compare
This PR (HEAD: 0e7e745) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/692237.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Jes Cok:
Patch Set 5: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-19T14:10:26Z","revision":"b03a4497fae06a8fdca53e58448c34ac35dc7621"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 5: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from qiu laidongfeng:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from qiu laidongfeng:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 5: Auto-Submit+1 Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Cherry Mui:
Patch Set 5: Code-Review+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jonathan Amsterdam:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 5: -Auto-Submit -Code-Review
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Fixes golang#65954 Change-Id: I88f880977782e632ed71699272e3e5d3985ea37b
Change-Id: I2effccfd296366065ee9626a9674cd637b702218
Change-Id: I98eda168e7630f523184b23b38c629b42eebedde
Change-Id: I4830410ed2ea9e74550eaa5e5722e3b9aeb80d16
Change-Id: I8dc2a9e008e945e7338b3f1ab14216c99442f15e
Change-Id: I5d5d1d70b323bf83e61f186d5ab8b6ebc087346e
Change-Id: Icae5ca0615da377ae22a1ae0989f868decbd4fc0
0e7e745
to
34a36ea
Compare
This PR (HEAD: 34a36ea) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/692237.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Jes Cok:
Patch Set 6: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-08-27T14:29:21Z","revision":"1fbb5bf32ead2e55517274ed5c7a60e34604f8e8"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 6:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 6: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/692237.
After addressing review feedback, remember to publish your drafts!
Fixes #65954