-
Notifications
You must be signed in to change notification settings - Fork 18.4k
cmd/go: invalidate coverage report cache when coverpkg sources change #74773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: invalidate coverage report cache when coverpkg sources change #74773
Conversation
This PR (HEAD: bb12492) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!
Message from Jorropo:
Patch Set 1: Commit-Queue+1
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2025-07-29T11:16:25Z","revision":"7c78557e0f55c0fbd57694af257866cdad171575"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!
Message from Jorropo:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!
bb12492 to
f7cd72d
Compare
This PR (HEAD: f7cd72d) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Ryan Currah:
Patch Set 2:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/690775.
After addressing review feedback, remember to publish your drafts!
f7cd72d to
cb64dbe
Compare
This PR (HEAD: cb64dbe) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
cb64dbe to
ca629f2
Compare
ca629f2 to
5e0f1be
Compare
This PR (HEAD: 5e0f1be) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
5e0f1be to
d0fbeeb
Compare
This PR (HEAD: d0fbeeb) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
d0fbeeb to
e85b4c0
Compare
This PR (HEAD: e85b4c0) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
When using -coverpkg with coverage profiling, the coverage cache keys did not include the source file hashes of the covered packages. This could result in stale coverage reports that reference outdated line numbers when covered package sources were modified between test runs. This change adds a cached hash of the covered packages' source files that gets included in the coverage cache key computation. The hash is computed once per test execution using sync.Once to avoid redundant file system operations across multiple test packages. The fix ensures that coverage profiles are properly invalidated when any source file in the covered packages changes, preventing cache hits with stale line number references. Fixes golang#74873
e85b4c0 to
d8307ea
Compare
This PR (HEAD: d8307ea) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/690775.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Uh oh!
There was an error while loading. Please reload this page.
When using -coverpkg with coverage profiling, the coverage cache keys
did not include the source file hashes of the covered packages. This
could result in stale coverage reports that reference outdated line
numbers when covered package sources were modified between test runs.
This change adds a cached hash of the covered packages' source files
that gets included in the coverage cache key computation. The hash is
computed once per test execution using sync.Once to avoid redundant
file system operations across multiple test packages.
The fix ensures that coverage profiles are properly invalidated when
any source file in the covered packages changes, preventing cache
hits with stale line number references.
Fixes #74873