-
Notifications
You must be signed in to change notification settings - Fork 18.4k
math: improve math.Log to handle subnormal floating number on amd64 #56601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: d584d8d) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/448216 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/448216.
After addressing review feedback, remember to publish your drafts!
...on amd64 The existing implementation for math.Log on amd64/s390x, math/log_amd64.S, doesn't normalize subnormal IEEE 64-bit floating point number correctly. This only occurs on amd64/s390x. The go implementation of log, which is used on other architecture does handle subnormal floating number correctly. This commit add normalize logic to math/log_amd64.S. Fixes golang#56600
d584d8d to
d6edc2c
Compare
This PR (HEAD: d6edc2c) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/448216 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
The existing implementation for math.Log on amd64/s390x, math/log_amd64.S,
doesn't normalize subnormal IEEE 64-bit floating point number correctly.
This only occurs on amd64/s390x. This commit add normalize logic to
math/log_amd64.S.
Fixes #56600