Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

net/http: convert URL credentials to Authorization header for js fetch #56564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bored-engineer wants to merge 1 commit into golang:master
base: master
Choose a base branch
Loading
from bored-engineer:patch-2
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/net/http/roundtrip_js.go
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,17 @@ func (t *Transport) RoundTrip(req *Request) (*Response, error) {
headers.Call("append", key, value)
}
}
// If the URL has credentials, convert to an Authorization header
url := *req.URL
if url.User != nil {
url.User = nil
if req.Header.Get("Authorization") == "" {
username := url.User.Username()
password, _ := url.User.Password()
authorization := "Basic " + basicAuth(username, password)
headers.Call("append", "Authorization", authorization)
}
}
opt.Set("headers", headers)

if req.Body != nil {
Expand All @@ -112,7 +123,7 @@ func (t *Transport) RoundTrip(req *Request) (*Response, error) {
}
}

fetchPromise := js.Global().Call("fetch", req.URL.String(), opt)
fetchPromise := js.Global().Call("fetch", url.String(), opt)
var (
respCh = make(chan *Response, 1)
errCh = make(chan error, 1)
Expand Down

AltStyle によって変換されたページ (->オリジナル) /