-
Notifications
You must be signed in to change notification settings - Fork 18.4k
crypto/x509: add String() for KeyUsage, ExtKeyUsage #56005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: a0ab89f) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/437875 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Ian Lance Taylor:
Patch Set 1: Hold+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
a0ab89f to
5f08ad7
Compare
This PR (HEAD: 5f08ad7) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/437875 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gabor Tanz:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
This is mainly useful for (pretty-)printing certificates.
5f08ad7 to
a4898c0
Compare
This PR (HEAD: a4898c0) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/437875 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gabor Tanz:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from tricium-prod@appspot.gserviceaccount.com:
Patch Set 4:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 4: Hold+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-02-13T18:23:48Z","revision":"c84a435e9de2bac51c30b7e4db7d62e1dfd2f5cb"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 4: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-wasip1-wasm_wasmtime has failed with summary (view all results):
FAILURE
- go on master (change 437875)
Error:
shard 1: failed to run "make.bash": exit status 1
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 4: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-02-13T19:00:56Z","revision":"5a7c9118fa616f97ea95d9bded7357eddc7c567d"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 5: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5:
This CL has failed the run. Reason:
Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):
FAILURE
- go on master (change 437875)
Error:
shard 1: failed to run "make.bash": exit status 2
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 5: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 661a666) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/437875.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gabor Tanz:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 6: Code-Review+2 Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-02-20T16:47:38Z","revision":"58a40e6e84942b32bf65daad120560313db891c6"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 6: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6:
This CL has failed the run. Reason:
Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):
FAILURE
- go on master (change 437875)
- tools on master (commit 51dec25)
Error:
failed to run "make.bash": exit status 2
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 6: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 7: Code-Review+2
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Emmanuel Odeke:
Patch Set 7: Code-Review+2 Run-TryBot+1
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 7:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 7:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 7: TryBot-Result-1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
Message from Jes Cok:
Patch Set 7:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/437875.
After addressing review feedback, remember to publish your drafts!
@izolight thanks for your work on this change; however there have been a couple of changes waiting for you to address on CL https://go-review.googlesource.com/c/go/+/571035; please take a look and address them or if not able to, kindly let us know and we can take on the work in another CL. Thank you!
Uh oh!
There was an error while loading. Please reload this page.
This is mainly useful for (pretty-)printing certificates.
fixes #56866