Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

mime: range glob expansions in type_unix.go #53974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikola-jokic wants to merge 3 commits into golang:master
base: master
Choose a base branch
Loading
from nikola-jokic:nikola-jokic/mime-glob-range-expansion

Conversation

Copy link
Contributor

@nikola-jokic nikola-jokic commented Jul 20, 2022
edited
Loading

Fixes #52609
Fixes #54793

Copy link
Contributor

This PR (HEAD: b41e88d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/418556 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

This PR (HEAD: 37f7999) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/418556 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Contributor

Message from Damien Neil:

Patch Set 2:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

This PR (HEAD: ebae55c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/418556 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Copy link
Contributor

Message from Nikola Jokic:

Patch Set 3:

(8 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Nikola Jokic:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Damien Neil:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Nikola Jokic:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Damien Neil:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Nikola Jokic:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Hold+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Copy link
Contributor

Message from Nikola Jokic:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/418556.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone

AltStyle によって変換されたページ (->オリジナル) /