-
Notifications
You must be signed in to change notification settings - Fork 18.4k
syscall/js: enable a JS Promise pattern for Funcs #52581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
For more information, open the CLA check for this pull request.
This PR (HEAD: 034ea79) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/402455 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/402455.
After addressing review feedback, remember to publish your drafts!
I was working with Go and WASM today, and registering functions with
js.Global().Set("someAlias", FuncOf(someFunc))
works, but without error handling the program quickly exits after one wrong call from the JS side to global.someAlias()
.
This PR proposes to adopt a pattern that is already in use in the community to resolve requests to the Go code with promises, and could be useable by:
js.Global().Set("someAlias", PromiseOf(somePromiseAbleFunc))
where the only difference should be is that somePromiseAbleFunc
should return an interface and error, which it can then use to either resolve or reject the promise safely with await global.someAlias()
.
Recover by deferring a reject call if there is any error or panic. Also, parse any error or panic into a plain simple error to be handled regularly.
This PR (HEAD: cc420cd) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/402455 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
This PR (HEAD: c19a452) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/402455 to see it.
Tip: You can toggle comments from me using the comments
slash command (e.g. /comments off
)
See the Wiki page for more info
I saw this in https://brunoluiz.net/blog/2022/aug/imagewand-privacy-first-image-conversion-experiment-with-golang-and-wasm/. I've written basically the same helper in my own WASM project, so I agree this serves a very common need, but it's new API, so you need to go through the Go proposal process. Go to the Issue tab and create a new issue called "proposal: syscall/js: add PromiseOf" and start a discussion there. If approved, your PR can be merged afterwards.
Methods using js.PromiseOf return a js.Func that is callable using async/await in JS.