-
Notifications
You must be signed in to change notification settings - Fork 18.4k
math: add ARM64 implementation of hypot #47536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 1bc07c8) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/339849 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Hau Yang:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Robert Griesemer:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from fannie zhang:
Patch Set 1: Run-TryBot+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
1bc07c8 to
52f73f1
Compare
This PR (HEAD: 52f73f1) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/339849 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Hau Yang:
Patch Set 2:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
52f73f1 to
e85ba85
Compare
This PR (HEAD: e85ba85) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/339849 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Russ Cox:
Patch Set 3: Hold+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Fixes golang#53522 Change-Id: Ibed838d358a733d26a6c3d89446d7fadb1012961 Reviewed-on: https://go-review.googlesource.com/c/go/+/413876 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
e85ba85 to
1d646a5
Compare
This PR (HEAD: 1d646a5) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/go/+/339849 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Hau Yang:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Hau Yang:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Robert Griesemer:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Fannie Zhang:
Patch Set 1: Run-TryBot+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1: TryBot-Result+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Hau Yang:
Patch Set 2:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Russ Cox:
Patch Set 3: Hold+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Message from Hau Yang:
Patch Set 4:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/339849.
After addressing review feedback, remember to publish your drafts!
Add ARM64 assembly implementation of hypot. The benchmark which run on
Apple Silicon M1 chip is listed as following.
BenchmarkHypot
BenchmarkHypot-8 2.185 ns/op 0 B/op 0 allocs/op
BenchmarkHypotGo
BenchmarkHypotGo-8 3.462 ns/op 0 B/op 0 allocs/op
delta: -36.89%