Skip to content

cmd/internal/goobj: remove unused fields of Reader #47085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

qingyunha wants to merge 2 commits into golang:master

from qingyunha:goobj

+3 −7

Open

cmd/internal/goobj: remove unused fields of Reader #47085

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

cmd/internal/goobj: remove unused fields of Reader

qingyunha Jul 7, 2021

cmd/internal/goobj: remove unused fields of Reader

qingyunha Jul 7, 2021

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

10 changes: 3 additions & 7 deletions src/cmd/internal/goobj/objfile.go

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -19,14 +19,12 @@
		package goobj

		import (
	"bytes"
		"cmd/internal/bio"
		"crypto/sha1"
		"encoding/binary"
		"errors"
		"fmt"
		"internal/unsafeheader"
	"io"
		"unsafe"
		)

Expand Down Expand Up		@@ -589,16 +587,14 @@ func (w *Writer) Offset() uint32 {
		}

		type Reader struct {
	b []byte // mmapped bytes, if not nil
	b []byte
		readonly bool // whether b is backed with read-only memory

	rd io.ReaderAt
	start uint32
	h Header // keep block offsets
	h Header // keep block offsets
		}

		func NewReaderFromBytes(b []byte, readonly bool) *Reader {
	r := &Reader{b: b, readonly: readonly, rd: bytes.NewReader(b), start: 0}
	r := &Reader{b: b, readonly: readonly}
		err := r.h.Read(r)
		if err != nil {
		return nil
Expand Down