Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[1.9] optimize readPacket (#1705) #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 1 commit into go-sql-driver:1.9 from methane:opt-read-19
Apr 25, 2025
Merged

Conversation

Copy link
Member

@methane methane commented Apr 24, 2025 •
edited
Loading

Description

Avoid unnecessary allocation.

Although this is not a bug, this is a regression in 1.9 branch.
This PR fixes performance regression when compression is not used.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file
 

Avoid unnecessary allocation.
Copy link

coderabbitai bot commented Apr 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@methane methane requested a review from Copilot April 24, 2025 11:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the readPacket implementation to reduce unnecessary allocations and improve performance when compression is not used. The changes refactor the read logic by introducing a new readNext method on mysqlConn, update the compress functions to remove redundant reader function parameters, and add a convenient len method to the buffer type.

  • Introduce mysqlConn.readNext to centralize buffer reading and timeout handling.
  • Refactor compress.go to eliminate the extra readerFunc parameter.
  • Add a len method to buffer.go to expose the buffer’s current length.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packets.go Added a new readNext function and updated readPacket to use it.
compress.go Removed the readerFunc parameter from readNext and readCompressedPacket.
buffer.go Added a len method and updated readNext to work without error returns.

Copy link

Coverage Status

coverage: 82.809% (-0.08%) from 82.884%
when pulling b32b0e8 on methane:opt-read-19
into 2ed589b on go-sql-driver:1.9.

@methane methane changed the title (削除) optimize readPacket (#1705) (削除ここまで) (追記) [1.9] optimize readPacket (#1705) (追記ここまで) Apr 24, 2025
@methane methane enabled auto-merge (squash) April 25, 2025 12:20
@methane methane disabled auto-merge April 25, 2025 12:21
@methane methane merged commit dfd973a into go-sql-driver:1.9 Apr 25, 2025
36 checks passed
@methane methane deleted the opt-read-19 branch April 25, 2025 12:21
hantang pushed a commit to qundao/mirror-forgejo that referenced this pull request Jun 14, 2025 
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) | require | patch | `v1.9.2` -> `v1.9.3` |
---
### Release Notes
<details>
<summary>go-sql-driver/mysql (github.com/go-sql-driver/mysql)</summary>
### [`v1.9.3`](https://github.com/go-sql-driver/mysql/releases/tag/v1.9.3)
[Compare Source](go-sql-driver/mysql@v1.9.2...v1.9.3)
#### What's Changed
- \[1.9] test stability improvement. by [@&#8203;methane](https://github.com/methane) in go-sql-driver/mysql#1699
- \[1.9] Transaction Commit/Rollback returns conn's cached error by [@&#8203;methane](https://github.com/methane) in go-sql-driver/mysql#1702
- backport benchmark_test by [@&#8203;methane](https://github.com/methane) in go-sql-driver/mysql#1706
- \[1.9] optimize readPacket ([#&#8203;1705](go-sql-driver/mysql#1705)) by [@&#8203;methane](https://github.com/methane) in go-sql-driver/mysql#1707
- \[1.9] fix PING on compressed connections by [@&#8203;methane](https://github.com/methane) in go-sql-driver/mysql#1723
- release v1.9.3 by [@&#8203;methane](https://github.com/methane) in go-sql-driver/mysql#1725
**Full Changelog**: go-sql-driver/mysql@v1.9.2...v1.9.3
</details>
---
### Configuration
📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC40OC40IiwidXBkYXRlZEluVmVyIjoiNDAuNDguNCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19-->
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8186
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /