-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Introduce RegisterReaderHandlerWithEncoderInfo #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2023
It is the same as RegisterReaderHandler, but receives some configuration settings which are needed to correctly encode the TSV. (For now only the Location). issue go-sql-driver#1416
@Jille
Jille
force-pushed
the
reader-config
branch
from
April 26, 2023 08:16
39a9638 to
6f7eca0
Compare
@Jille
Jille
changed the title
(削除) Introduce RegisterReaderHandlerWithConfig (削除ここまで)
(追記) Introduce RegisterReaderHandlerWithEncoderInfo (追記ここまで)
Apr 26, 2023
You are not saying why the time.Location of the DSN is useful for encoding the TSV.
Some example code (ideally provided as a testable example) would be helpful for review as well as for end users.
See @methane comment in #1416 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Introduce RegisterReaderHandlerWithEncoderInfo
It is the same as RegisterReaderHandler, but receives some configuration
settings which are needed to correctly encode the TSV. (For now only the
Location).
for issue #1416
Checklist