Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

use experimental go json v2 library #35392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
junoberryferry wants to merge 13 commits into go-gitea:main
base: main
Choose a base branch
Loading
from junoberryferry:jsonv2

Conversation

Copy link
Contributor

@junoberryferry junoberryferry commented Aug 31, 2025

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2025
techknowlogick and others added 2 commits September 1, 2025 19:35 
Signed-off-by: techknowlogick <matti@mdranta.net>
 
Signed-off-by: techknowlogick <matti@mdranta.net>
 
Signed-off-by: techknowlogick <matti@mdranta.net>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 2, 2025 
Signed-off-by: techknowlogick <matti@mdranta.net>
techknowlogick and others added 4 commits September 2, 2025 19:57 
Signed-off-by: techknowlogick <matti@mdranta.net>
Signed-off-by: techknowlogick <matti@mdranta.net>
Signed-off-by: techknowlogick <matti@mdranta.net>
Copy link
Member

@junoberryferry I'm sorry for all the notifications. I've just resolved the linting errors on my phone. Thanks for this PR!

 

Signed-off-by: techknowlogick <matti@mdranta.net>
Copy link
Member

lunny commented Sep 3, 2025

Since it's not enabled by default. GOEXPERIMENT=jsonv2 is needed. I don't think this should be merged into v1.25

 

Signed-off-by: techknowlogick <matti@mdranta.net>
Copy link
Member

@lunny this PR allows for jsonv2 to be enabled by default once swagger/go issues are solved. We have other optional tags as well, and this could be one of them for those who want to build the binary with the experimental library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code modifies/internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /