-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove git.Commit referenced Tree object to let it portable #35356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+709
−695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lunny
lunny
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Aug 25, 2025
@GiteaBot
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Aug 25, 2025
@github-actions
github-actions
bot
added
modifies/api
This PR adds API routes or modifies them
modifies/go
Pull requests that update Go code
labels
Aug 25, 2025
@lunny
lunny
force-pushed
the
lunny/remove_repo_ref_in_commit
branch
from
August 25, 2025 19:36
fc59665 to
4a8637f
Compare
@lunny
lunny
changed the title
(削除) Remove git.Commit referenced repo to let it portable (削除ここまで)
(追記) Remove git.Commit referenced Tree object to let it portable (追記ここまで)
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR removes a flawed design where
git.Commitdepended ongit.Tree, andgit.Treein turn depended ongit.Repository.Now,
git.Commitonly stores theTreeIDas a field. To retrieve the tree of a commit, you can useNewTree.This change makes
git.Commitmore portable, allowing commit objects to be transferred across machines when necessary.submoduleCachetoTreeas field and renameCommitSubmoduleFiletoSubmoduleFile