Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Use gitrepo.SetDefaultBranch when set default branch of wiki repository #33911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 9 commits into go-gitea:main from lunny:lunny/reafctor_setdefaultbranch
Aug 28, 2025

Conversation

Copy link
Member

@lunny lunny commented Mar 16, 2025

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 16, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Mar 16, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 17, 2025
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should stop here.

The design is wrong.

You can't make every function do "for repo" and "for wiki".

Since wiki is also a git repo, it should share the same repo interface as a code repo.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Mar 27, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2025
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design of StorageRepo is buggy and will cause more abuses or bugs.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 28, 2025
@lunny lunny changed the title (削除) Move SetDefaultBranch to gitrepo (削除ここまで) (追記) Use gitrepo.SetDefaultBranch when set default branch of wiki repository (追記ここまで) Mar 30, 2025
Copy link
Member Author

lunny commented Mar 30, 2025

Updated to revert the new interface of the StorageRepo, now it will use gitrepo.SetDefaultBranch when set default branch of wiki repository.

@lunny lunny requested a review from wxiaoguang August 24, 2025 17:13
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Aug 24, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 28, 2025
@lunny lunny enabled auto-merge (squash) August 28, 2025 05:05
@lunny lunny merged commit fb056bf into go-gitea:main Aug 28, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Aug 28, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 28, 2025
@wxiaoguang wxiaoguang deleted the lunny/reafctor_setdefaultbranch branch August 28, 2025 09:07
hiifong added a commit to hiifong/gitea that referenced this pull request Aug 31, 2025 
* main: (34 commits)
 when sorting issues by nearest due date, issues without due date should be sorted ascending (go-gitea#35267)
 [skip ci] Updated translations via Crowdin
 Upgrade xz to v0.5.15 (go-gitea#35377)
 Refactor db package (go-gitea#35380)
 Remove the duplicated function GetTags (go-gitea#35375)
 [skip ci] Updated translations via Crowdin
 Allow foreachref parser to grow its buffer (go-gitea#35365)
 Remove global context from db package (go-gitea#35371)
 Use gitrepo.SetDefaultBranch when set default branch of wiki repository (go-gitea#33911)
 Deleting branch could delete broken branch which has database record but git branch is missing (go-gitea#35360)
 Remove incorrect "db.DefaultContext" usages (go-gitea#35366)
 Refactor to use reflect.TypeFor (go-gitea#35370)
 [skip ci] Updated translations via Crowdin
 Remove wrong "git.DefaultContext" (go-gitea#35364)
 Fix context usages (go-gitea#35348)
 Instance signing rule `pubkey` should allow all public keys, not just GPG (go-gitea#35357)
 Allow deleting comment with content via API like web did (go-gitea#35346)
 Prevent duplicate actions email (go-gitea#35215)
 rename nightly docker tag for main branch (go-gitea#35344)
 Fix atom/rss mixed error (go-gitea#35345)
 ...
# Conflicts:
#	tests/integration/pull_merge_test.go
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 1, 2025 
* giteaofficial/main:
 [skip ci] Updated translations via Crowdin
 when sorting issues by nearest due date, issues without due date should be sorted ascending (go-gitea#35267)
 [skip ci] Updated translations via Crowdin
 Upgrade xz to v0.5.15 (go-gitea#35377)
 Refactor db package (go-gitea#35380)
 Remove the duplicated function GetTags (go-gitea#35375)
 [skip ci] Updated translations via Crowdin
 Allow foreachref parser to grow its buffer (go-gitea#35365)
 Remove global context from db package (go-gitea#35371)
 Use gitrepo.SetDefaultBranch when set default branch of wiki repository (go-gitea#33911)
 Deleting branch could delete broken branch which has database record but git branch is missing (go-gitea#35360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lafriks lafriks lafriks approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

+2 more reviewers

@a1012112796 a1012112796 a1012112796 approved these changes

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /