-
Notifications
You must be signed in to change notification settings - Fork 107
fix: enforce secret/read checks on attachment download routes#649
Open
ksw9722 wants to merge 1 commit into
Open
fix: enforce secret/read checks on attachment download routes #649ksw9722 wants to merge 1 commit into
ksw9722 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
비밀글/제한글의 첨부파일 다운로드 경로에서 본문 조회와 동일한 접근통제(읽기/비밀글 검증)가 누락되어 있던 문제를 수정합니다.
변경 사항
DownloadFileService에validate_download_access()추가block_read_comment()validate_read_level()validate_secret()bbs/board.py)에서 파일 반환 전validate_download_access()호출api/v1/routers/board.py)에서 파일 반환 전validate_download_access()호출보안 효과
관련 이슈