-
Notifications
You must be signed in to change notification settings - Fork 866
rough draft: attempt to make keep an extra
#458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempt to make `keep` an extra to put it on the PATH when installing via pipx/homebrew related: gleitz#425
Owner
gleitz
commented
Mar 24, 2022
This is a valiant effort, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
attempt to make
keepan extra to put it on the PATH when installing via pipx/homebrewFor anyone who might have time to take up the mantle of keeping keep on the PATH here (see #425 for context):
I missed a quote. Let's pretend it was intentional to keep this rush-job from getting merged in ;) I have no experience with setuptools and unfortunately don't have more time to tinker- just stumbled across this potential solution and thought I should share
Of particular interest in #425 thread, last comment: as mentioned, consider use case where user opts not to install keep.
How to test:
I think you should be able to clone this branch, fix the quote, and
pipx install .[keep]Not sure how to test w/
brew@gleitz feel free to close if this just adds noise to your repo i wont be offended :)
Please provide detailed instructions for testing your changes locally, including expected response/behavior.
Pull Request checklist:
nose2).python setup.py lint)..envincluded.Known bugs (if any):
If there are bugs in your current changes you can still open the PR and mention the bugs you found. Propose further changes that can help fix bugs in your current changes.