-
-
Notifications
You must be signed in to change notification settings - Fork 653
Update which requirement from 7.0 to 8.0 #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are there any reasons to update this dependency specifically? Just curious, I’m not questioning that these kinds of updates are generally useful.
Are there any reasons to update this dependency specifically? Just curious, I’m not questioning that these kinds of updates are generally useful.
Based on https://github.com/harryfei/which-rs/blob/8.0.0/CHANGELOG.md, the immediate benefits are rather minor: better handling of I/O errors, and one fewer dependency.
(I filed this PR while updating the rust-which package in Fedora. I patched packages as needed to avoid a rust-which7 compat package, and it’s our policy to offer patches upstream.)
one fewer dependency.
Thats actually the opposite if you check the diff on the lock file. I would defer this one until we have a chance to not duplicate the rustix dependency
This Pull Request fixes/closes #{issue_num}.v N/A
It changes the following:
whichdependency inCargo.tomlfrom 7.0 to 8.0Cargo.lockwithcargo update which.I followed the checklist:
make checkwithout errors. (On Fedora 42, I needed to useCC=clang CXX=clang++becauseonig_sysdoes not build with GCC 15 due to incompatible pointer types in the oniguruma C code. I also neededpython-unversioned-commandinstalled, and I needed tocargo install cargo sort. None of this has anything to do with this PR.)