-
-
Notifications
You must be signed in to change notification settings - Fork 650
Fix typos #2649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #2649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@ada4a
ada4a
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one was actually right, or at least intentional -- get_visible returns for each tree item whether it's visible or not, so a list of visibles, so a visibles. If anything, I would rename both the variable and the helper function to visibilities and get_visibilities, respectively
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ada4a FYI. I tried update the changes, but obtain lots of errors during make check. Hence, I reverted the changes to keep the fixes small.
4940d04 to
289e957
Compare
This Pull Request fixes/closes #{issue_num}.
It changes the following:
typos --hidden --format briefI followed the checklist:
make checkwithout errors