Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: disable blame and history popup for untracked files #2489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpbaks wants to merge 3 commits into gitui-org:master
base: master
Choose a base branch
Loading
from kpbaks:bugfix/disable-blame-history-popup-for-untracked-files

Conversation

Copy link

@kpbaks kpbaks commented Jan 18, 2025 •
edited
Loading

An untracked file does not have any history data. Right now when you press B for the blame popup or the H for the history popup you get an empty popup where the title spins endlessly trying to find the file in the commit history, and show relevant information. This commit

It changes the following:

  • disables the two actions in the StatusTreeComponent, when the selected item is a file which is not tracked by git.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

Copy link
Author

kpbaks commented Jan 18, 2025

I have run make check. The only error reported by clippy is this.
image

Hope this is okay. I think it could be addressed in another PR to refactor the cognitive complexity of the event function

Copy link
Contributor

I would add #[expect(clippy::cognitive_complexity)] to the function. make check should not fail. The refactor should be done in a future pr.
extrawurst and kpbaks reacted with thumbs up emoji

Copy link
Author

kpbaks commented Jan 19, 2025

I have added #[expect(clippy::cognitive_complexity)] to the function. Now make check passes.

@kpbaks kpbaks force-pushed the bugfix/disable-blame-history-popup-for-untracked-files branch from 42254f7 to 97d5e5b Compare January 22, 2025 16:57
Copy link
Collaborator

@kpbaks thanks for your contribution. please add a changelog entry and its good to go
kpbaks reacted with thumbs up emoji

Copy link
Collaborator

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry matching other changelog entries style

kpbaks added 3 commits August 30, 2025 23:32 
An untracked file does not have any history data. Right now when
you press `B` for the blame popup or the `H` for the history popup
you get an empty popup where the title spins endlessly trying to find
the file in the commit history, and show relevant information.
This commit disables the two actions in the `StatusTreeComponent`, when the
selected item is a file which is not tracked by git.
@kpbaks kpbaks force-pushed the bugfix/disable-blame-history-popup-for-untracked-files branch from fcdba06 to 9b76e4c Compare August 30, 2025 21:38
Copy link
Author

kpbaks commented Aug 30, 2025

Added entry to CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@extrawurst extrawurst extrawurst requested changes

Assignees
No one assigned
Projects
None yet
Milestone
v0.28
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /