-
Notifications
You must be signed in to change notification settings - Fork 28
Add support for Python 3.10, drop EOL 3.5 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a million!
Looking at the minimal required version of GitPython, it should be safe to have a patch release to be OK with the current version of it. But what about older ones? Maybe a major version bump would be in order to avoid breakage?
@hugovk What's your opinion on this?
Most projects bump the major version when dropping a Python version (and I generally do too), and it's quite a good way to flag it.
But some don't. As long as python_requires is set, pip should still install only a version of the library which matches their running Python, so there should be no sudden breakages.
It looks like the version constraints are set to allow smmap to turn into 5.0: smmap<5,>=3.0.1.
Let me merge this PR and release version 5 accordingly: https://pypi.org/project/smmap/5.0.0/
Python 3.10 was released on 2021年10月04日:
We can also take the opportunity to drop EOL Python 3.5, and upgrade Python syntax for 3.6+.
nose is abandoned and unmaintained, last release was 6.5 years ago (https://pypi.org/project/nose/) and it no longer works with Python 3.10 (nose-devs/nose#1099). So let's switch to pytest.
We also don't need to create universal wheels, they're for supporting Python 2 and 3.