-
Notifications
You must be signed in to change notification settings - Fork 67
Revert "Drop support for EOL Python 3.7" #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings back Python 3.7 support (allowing it to be installed on 3.7, and testing on 3.7 on CI), even though 3.7 is end-of-life, because support for 3.7 is not being dropped by GitPython yet, and there is value in keeping the version ranges supported by GitPython and gitdb consistent. This reverts commit 875acb4.
@EliahKagan
EliahKagan
force-pushed
the
py37
branch
from
September 11, 2023 09:23
0f54d4f to
bd21ed4
Compare
Perfect, thank you!
EliahKagan
added a commit
to EliahKagan/smmap
that referenced
this pull request
Sep 17, 2023
Analogous to gitpython-developers/gitdb#94, this brings back Python 3.7 support (allowing it to be installed on 3.7, and testing on 3.7), even though 3.7 is end of life, because support for 3.7 is not being dropped by GitPython (or gitdb) yet, and there is value in keeping GitPython, gitdb, and smmap consistent. This reverts commit f1b4d14.
This was referenced Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This brings back Python 3.7 support (allowing it to be installed on 3.7, and testing on 3.7 on CI), even though 3.7 is end-of-life. The reason is that support for 3.7 is not being dropped by GitPython yet, and there is value in keeping the version ranges supported by GitPython and gitdb consistent. This is noted in review comments on gitpython-developers/GitPython#1654.
This reverts commit 875acb4.