Never add a vendored smmap directory to sys.path #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Byron merged 1 commit into gitpython-developers:master from EliahKagan:nopathmod

Oct 20, 2023

Merged

Never add a vendored smmap directory to sys.path #102

Byron merged 1 commit into gitpython-developers:master from EliahKagan:nopathmod

Oct 20, 2023

Conversation

EliahKagan

Copy link

Member

@EliahKagan EliahKagan commented Oct 20, 2023 •

edited

Loading

This removes the logic that appended the git submodule directory for smmap to sys.path under most circumstances when the version of gitdb was not from PyPI. Now gitdb does not modify sys.path.

See GitPython#1717 and GitPython#1720 for context. This change is roughly equivalent to the change to GitPython, though as noted the behavior being eliminated is subtly different here and there.

Please note that this does not make any documentation changes (and the changes in #103 are not related to this).

@EliahKagan


 Never add a vendored smmap directory to sys.path

965d2d3

This removes the logic that appended the git submodule directory
for smmap to sys.path under most circumstances when the version
of gitdb was not from PyPI. Now gitdb does not modify sys.path.
See gitpython-developers/GitPython#1717
and gitpython-developers/GitPython#1720 for
context. This change is roughly equivalent to the change to
GitPython, though as noted the behavior being eliminated is subtly
different here and there.

This was referenced Oct 20, 2023

We appear to import the submodule version of gitdb (but never do) gitpython-developers/GitPython#1717

Closed

Never modify sys.path gitpython-developers/GitPython#1720

Merged

Revise and update the readme #103

Merged

Byron

Byron approved these changes

Oct 20, 2023

View reviewed changes