Remove duplicate license parameter #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Byron merged 1 commit into gitpython-developers:master from blag:master

Nov 7, 2019

Merged

Remove duplicate license parameter #958

Byron merged 1 commit into gitpython-developers:master from blag:master

Nov 7, 2019

Conversation

blag

Copy link

Contributor

@blag blag commented Nov 6, 2019

The Python packaging specifications indicate that the license parameter to setup() should be used in one of the following cases:

the license is not a selection from the "License" Trove classifiers
to specify a particular version of a license which is named via the Classifier field
to indicate a variation or exception to such a license

This PR removes the explicit license parameter since the usage for this project does not fit any of those cases and it makes it more difficult to use tools like pip-licenses since it is not consistent with other projects that just have License :: OSI Approved :: BSD License as one of their trove classifiers.

Please note that this does not change the license of the project in any way, and since this project already has a License :: OSI Approved :: BSD License trove classifier the license parameter is redundant.