-
-
Notifications
You must be signed in to change notification settings - Fork 954
Fix 'PushInfo' object has no attribute 'name' #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thetwoj
thetwoj
changed the title
(削除) Fix #820 (削除ここまで)
(追記) Fix 'PushInfo' object has no attribute 'name' (追記ここまで)
Oct 24, 2019
Thanks a lot, @thetwoj , and thanks for the great explanation of the issue! You wouldn't believe how much it helps me to wrap my head around code I have written nearly 10 years ago 😅.
I absolutely agree with the reasoning and would prefer risking breakage through a (theoretical) interface change over not fixing the issue arising from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #820
As identified in the issue, running the following short script:
Results in an exception like:
This is a bit of a misleading exception because
results
is actually anIterableList(PushInfo, ...)
, not an instance ofPushInfo
. The implementation ofIterableList
is looking for thename
attribute on the items it contains because that's theid_attr
that is provided when theIterableList
is created in_get_push_info()
:Unfortunately this doesn't pan out well because
PushInfo
doesn't contain aname
attribute, so the functionality thatIterableList
implements breaks down.One way to resolve the issue would be to simply reference the
PushInfo
directly:But the current exception prevents that from being obvious. After reading through the functionality exposed by
IterableList
I don't believe that it is actually providing any particular usefulness in this case becausePushInfo
doesn't contain any attributes that make for a logicalid_attr
. I think it makes more sense to replace this use ofIterableList
with a plain oldlist
, that way the exception becomes much more helpful: