-
-
Notifications
You must be signed in to change notification settings - Fork 954
Fix/deepsource issues #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/deepsource issues #952
Conversation
...nto fix/deepsource-issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your continued contribution to this project.
Even though I would love to merge, I think it's more important to not break the interface than to satisfy deepsource. Thus I would be great if there could be another solution. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank a lot for fixing the issue found in first review, your continued effort is much appreciated.
Now it looks like there is only one small fix to be made and conflicts to be resolved before it can be merged.
codecov-io
commented
Oct 28, 2019
Codecov Report
@@ Coverage Diff @@ ## master #952 +/- ## ========================================== + Coverage 93.52% 93.53% +0.01% ========================================== Files 59 59 Lines 9677 9680 +3 ========================================== + Hits 9050 9054 +4 + Misses 627 626 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! I can't wait to see deepsource happy one day :).
Uh oh!
There was an error while loading. Please reload this page.
I will continue with this further.