-
-
Notifications
You must be signed in to change notification settings - Fork 954
Global ConfigParser #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global ConfigParser #950
Conversation
codecov-io
commented
Oct 23, 2019
Codecov Report
@@ Coverage Diff @@ ## master #950 +/- ## ========================================= - Coverage 93.52% 93.5% -0.02% ========================================= Files 59 59 Lines 9677 9915 +238 ========================================= + Hits 9050 9271 +221 - Misses 627 644 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, it's looking great! I particularly like that the change is implemented without breaking compatibility.
There are just two minor things I saw when reviewing, please let me know what you think about them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your effort! It's a great improvement!
Happy to help!
fixes #775
We can instantiate a GitConfigParser with no files specified, if we do so, then it'll figure out where those files are. It does this by either having a
config_levelspecified to it or, in the case of a config reader, by default we might want to read from all configuration levels, just like is currently the case in Repo.config_writer(), so we iterate through all of them (except repository level) and add all files to the parser.If the repository level is specified, we raise a unique ValueError telling the user to use the Repo object instead.