-
-
Notifications
You must be signed in to change notification settings - Fork 954
Update test_docs.py #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test_docs.py #773
Conversation
Using "import as" is normally a time saver but for usability of the documentation, please consider removing osp and join with fully qualified calls for better snippet readability.
codecov-io
commented
Jul 15, 2018
Codecov Report
@@ Coverage Diff @@ ## master #773 +/- ## ========================================== - Coverage 94.69% 94.69% -0.01% ========================================== Files 59 59 Lines 9353 9352 -1 ========================================== - Hits 8857 8856 -1 Misses 496 496
Continue to review full report at Codecov.
|
Thanks a lot for your contribution! Along with that other PR which fixes the indentation, the tutorial should be so much easier to read and understand.
Using "import as" is normally a time saver but for usability of the documentation, please consider removing osp and join with fully qualified calls for better snippet readability.
I had some co-workers end up using popen commands vs using this library when I recommended GitPython as they did not understand how it worked from skimming the docs.
Sorry for not writing a test that fails... only a syntax change for readability.