-
Notifications
You must be signed in to change notification settings - Fork 279
Prevent every row from unmounting when one row is deleted #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@salhotra
salhotra
changed the title
(削除) Prevent every row from unmounting when one row is deleted (削除ここまで)
(追記) [WIP] Prevent every row from unmounting when one row is deleted (追記ここまで)
Nov 30, 2020
@salhotra
salhotra
force-pushed
the
master
branch
from
November 30, 2020 15:04
7a69703 to
b797455
Compare
@salhotra
salhotra
changed the title
(削除) [WIP] Prevent every row from unmounting when one row is deleted (削除ここまで)
(追記) Prevent every row from unmounting when one row is deleted (追記ここまで)
Nov 30, 2020
keremcubuk
commented
Feb 5, 2021
Hello, when this pull request will accepted? It solves my most of problems. Thanks @salhotra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR from the previous release (#47) fixes the remounting of the entire list when an item is deleted.
But each individual item still unmounts and mounts again when an item is deleted.
This causes issues when animations are run on mount. Please refer to issue #207
Please correct me if I'm wrong, if an item is deleted, I think we don't need to update the keys of each item.