This repository was archived by the owner on Aug 26, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
Merged
Conversation
@lgarron
lgarron
force-pushed
the
update-deprecation-notice
branch
from
August 1, 2025 19:29
bf77816 to
4452dec
Compare
Closed
@lgarron
lgarron
force-pushed
the
update-deprecation-notice
branch
4 times, most recently
from
August 1, 2025 19:47
f359cf0 to
dea67c7
Compare
Contributor
Author
lgarron
commented
Aug 1, 2025
- Uses JSDoc comments which ensure that the functions receive the correct types in TypeScript, while still allowing the code to be pasted into vanilla JS.
Wait, this part is not being picked up properly by TypeScript. Lemme fix that.
@lgarron
lgarron
force-pushed
the
update-deprecation-notice
branch
2 times, most recently
from
August 1, 2025 20:20
e15e219 to
8c8af29
Compare
Contributor
Author
lgarron
commented
Aug 1, 2025
- Uses JSDoc comments which ensure that the functions receive the correct types in TypeScript, while still allowing the code to be pasted into vanilla JS.
Wait, this part is not being picked up properly by TypeScript. Lemme fix that.
Looks like this is not possible, since apparently JSDoc annotations are ignored in .ts files. So the example will fail TypeScript checking in either JS or TS unless I complicate the code in a way that makes it even harder to understand. So I've just converted it fully to TS and added a comment at the top of the example snippet.
@lgarron
lgarron
force-pushed
the
update-deprecation-notice
branch
7 times, most recently
from
August 7, 2025 03:20
e10f901 to
ba5da8e
Compare
... is the "right" choice.
Technically the syntax for referring to an instance method is `PublicKeyCredential#toJSON()` but I think this is problematic. So I've avoided it.
@lgarron
lgarron
force-pushed
the
update-deprecation-notice
branch
from
August 7, 2025 03:34
622da7d to
88f0e8a
Compare
vcsjones
vcsjones
reviewed
Aug 8, 2025
Co-authored-by: Kevin Jones <vcsjones@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
It now:
await(which is well-supported by browsers but still errors in TypeScript unless you specifically configure it).@github/webauthn-json.