Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Comments

Add Branch Scanning#258

Open
JennieOhyoung wants to merge 9 commits intomaster from
feature_check_branch_commits
Open

Add Branch Scanning #258
JennieOhyoung wants to merge 9 commits intomaster from
feature_check_branch_commits

Conversation

@JennieOhyoung
Copy link

@JennieOhyoung JennieOhyoung commented Jul 23, 2019

I made some changes to this script because:

  1. The commit check is only looking at the default branch and not checking other branches. I added the '-b' option to enable branch scanning.
  2. Some customers are unsure how to get started, so I added a doc link on how to generate a token and specified the date format.

Copy link
Author

Note: please allow me to do the merging after review. I have a customer currently using the script off of this branch.

Copy link
Contributor

@JennieOhyoung this is really great! Can you update it to use spaces instead of tabs? The formatting of the additions makes some of the additions a bit hard to follow 🙏 🙇
JennieOhyoung reacted with thumbs up emoji JennieOhyoung reacted with heart emoji

Copy link
Contributor

@primetheus primetheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the suggested changes feature only allows one line at a time, but lines 119-145, as well as 266-269 have formatting issues as well. Might be a bit of a nit-pick, but helps with the readability when it's all formatted the same 🙇

JennieOhyoung reacted with rocket emoji 
Co-Authored-By: Jared Murrell <primetheus@github.com>
@github github deleted a comment from Aa88s Aug 12, 2019
end
# Get all the branches so we can loop through them
if @branches
@client.branches(repo).each do |branch|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JennieOhyoung: looks as if indenting is broken here

@primetheus primetheus dismissed their stale review March 20, 2020 14:18

misread notification

Copy link

all approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azizshamim azizshamim Awaiting requested review from azizshamim

@pholleran pholleran Awaiting requested review from pholleran

4 more reviewers

@jonico jonico jonico left review comments

@morongosteve morongosteve morongosteve approved these changes

@siddharthgavit451-arch siddharthgavit451-arch siddharthgavit451-arch approved these changes

@primetheus primetheus primetheus left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /