-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Comments
Include Github https repository getter utility#243
Open
alwell-kevin wants to merge 1 commit intomaster from
Open
Include Github https repository getter utility #243alwell-kevin wants to merge 1 commit intomaster from
alwell-kevin wants to merge 1 commit intomaster from
Conversation
jonico
jonico
approved these changes
Mar 20, 2020
Contributor
@jonico
jonico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See minor change suggestions inside
Comment on lines
+25
to
+30
const spiner = new Spinner('Retrieving your Project, please wait...');
spiner.start();
github.getRepo(gitHubMeta, spiner).then(function(repo) {
console.log("Got Project: ", gitHubMeta.repo)
spiner.stop();
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const spiner = new Spinner('Retrieving your Project, please wait...');
spiner.start();
github.getRepo(gitHubMeta, spiner).then(function(repo) {
console.log("Got Project: ", gitHubMeta.repo)
spiner.stop();
const spinner = new Spinner('Retrieving your Project, please wait...');
spinner.start();
github.getRepo(gitHubMeta, spinner).then(function(repo) {
console.log("Got Project: ", gitHubMeta.repo)
spinner.stop();
var download = require("download");
var request = require('request');
var getRepo = (inputs, spiner) => {
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
var getRepo = (inputs, spiner) => {
var getRepo = (inputs, spinner) => {
theyemeni
theyemeni
approved these changes
Jul 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a javascript utility which enables a developer to GET a private GitHub Repository from an Organization over HTTPS (no GIT) using the CLI.
@azizshamim